Change SyncMap supported types check style#3328
Merged
Conversation
loosebazooka
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Allow for future extension with more supported builders like jib, which is expected to produce a syncMap
loosebazooka
force-pushed
the
change-order-syncmap
branch
from
67dc164 to
ceb1a88
Compare
Codecov Report
|
balopat
approved these changes
Dec 3, 2019
Contributor
|
unrelated error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for future extension with more supported builders like
jib, which is expected to produce a syncMap
Just trying to get used to the skaffold code and go things with small PRs.