Cache expensive Go compilation and linting#3341
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Dec 9, 2019
Merged
Cache expensive Go compilation and linting#3341dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: David Gageot <david@gageot.net>
tejal29
approved these changes
Dec 6, 2019
Contributor
|
I dont' like the idea of using cache for unit test running. But again, our team wrote pants cache, and developers write bugs :) I am ok with trying this and then reverting in case we see false positives :) |
Contributor
Author
|
@tejal29 On linux, the test cache is disabled (with --count=1). So I thought the risk would only be that a mac/win test could be flaky and we wouldn't detect that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will significantly reduce "unit tests" and "checks" jobs on TravisCI.
Signed-off-by: David Gageot david@gageot.net