Add env vars to kaniko specs#3389
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Dec 18, 2019
Merged
Conversation
cyrildiagne
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
balopat
approved these changes
Dec 18, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #3115
Relates to #731
Fixes #731.
Description
This will give users the option to provide environment variables to the kaniko pod.
This should fix #731 and enable ECR support on regions other than the default one.
User facing changes
n/a
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes