Apply resource labels in the deployer#3390
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Dec 16, 2019
Merged
Apply resource labels in the deployer#3390dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
This prepares for having multiple deployers per skaffold.yaml, and ensures that every resource has the label of the proper deployer it was deployed with.
Codecov Report
|
7 tasks
dgageot
approved these changes
Dec 16, 2019
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2875, #3292
Should merge before : #3392
Description
This prepares for having multiple deployers per skaffold.yaml, and
ensures that every resource has the label of the proper deployer it was
deployed with.
User facing changes
n/a
Next PRs.
kubectl,kustomize,helm)skaffold.yamlto accept multiple deployer configurations in thedeployfield.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes