Skip to content

Better check for valid Kubernetes manifests#3404

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:init-valid-manifests
Dec 19, 2019
Merged

Better check for valid Kubernetes manifests#3404
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:init-valid-manifests

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Dec 18, 2019

Old code: checks the file's extension first and later parse those files.
New code: checks the file's extension first and parse those files early.

This allows yaml/json files that are not valid kubernetes manifest to be analyzed as build descriptors. For example package.json

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the init-valid-manifests branch from 11c342e to 7b69513 Compare December 18, 2019 18:10
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2019

Codecov Report

Merging #3404 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/util.go 100% <ø> (ø) ⬆️
pkg/skaffold/initializer/kubectl/kubectl.go 83.33% <100%> (+1.24%) ⬆️
pkg/skaffold/initializer/init.go 60.61% <100%> (-0.13%) ⬇️
pkg/skaffold/util/tar.go 52.87% <0%> (-4.6%) ⬇️

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Dec 19, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Dec 19, 2019
@balopat balopat merged commit fd3351b into GoogleContainerTools:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants