Convert git tag into proper docker tag#3407
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Dec 20, 2019
Merged
Convert git tag into proper docker tag#3407dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
balopat
reviewed
Dec 19, 2019
pkg/skaffold/build/tag/git_commit.go
Outdated
| return fmt.Sprintf("%s:%s", imageName, ref), nil | ||
| } | ||
|
|
||
| func gitTagToDockerTag(text string) string { |
Contributor
There was a problem hiding this comment.
Nit: I don't think there is anything got specific about this - and it doesn't say what it does: escapeAndTruncateAsTag?
Contributor
There was a problem hiding this comment.
Or sanitizeTag could be another option
balopat
reviewed
Dec 19, 2019
| if len(withAuthorizedPrefix) > 128 { | ||
| return withAuthorizedPrefix[0:128] | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I would also add a warning or maybe debug message for visibility when we do change the tag - when tags start to overlap accidentally,this can be a useful hint
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Contributor
Author
|
Fixed all the nits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3344