Cache Gradle downloads and Go build cache#3425
Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom Dec 20, 2019
Merged
Cache Gradle downloads and Go build cache#3425nkubala merged 1 commit intoGoogleContainerTools:masterfrom
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
dgageot
force-pushed
the
cache-gradle-maven-downloads
branch
2 times, most recently
from
2b58300 to
2a9d47c
Compare
dgageot
changed the title
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
cache-gradle-maven-downloads
branch
from
ea6b1ef to
4ec11c4
Compare
nkubala
approved these changes
Dec 20, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
"the build cache does not detect changes to C libraries imported with cgo. If you have made changes to the C libraries on your system, you will need to clean the cache explicitly"
so we'll just need to make sure to invalidate if we ever upgrade fsnotify i guess. other than that seems fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net