Vendor pack CLI code to build with Buildpacks#3445
Vendor pack CLI code to build with Buildpacks#3445dgageot merged 4 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
dgageot
force-pushed
the
pack
branch
7 times, most recently
from
9f8a143 to
f5ec78f
Compare
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
LGTM modulo the go-licenses churn (#3493)
|
@briandealwis you should be able to LGTM since all the changes are buildpacks related now. The go-licences part was merged. |
| if !artifact.ForcePull { | ||
| if err := b.pull(ctx, out, builderImage); err != nil { | ||
| return "", err |
There was a problem hiding this comment.
This is confusing: if we aren't force-pulling then we pull the image? Doesn't pack do this anyways? Or this needs a comment to explain why.
There was a problem hiding this comment.
pack is either pulling always or pulling never. This is trying to pullIfNotPresent. I'll update the code with a comment.
| if !artifact.ForcePull { | ||
| // If ForcePull is true, we let pack find and pull the run image | ||
| var err error | ||
| runImage, err = b.findRunImage(ctx, artifact, builderImage) |
There was a problem hiding this comment.
Doesn't pack already do this?
There was a problem hiding this comment.
pack is either pulling always or pulling never. This is trying to pullIfNotPresent. I'll update the code with a comment.
4 participants
No description provided.