Simplify kaniko after we removed the GCS build context#3455
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jan 15, 2020
Merged
Simplify kaniko after we removed the GCS build context#3455dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
TadCordle,
balopat,
briandealwis,
chanseokoh,
loosebazooka,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
simplify-kaniko
branch
3 times, most recently
from
31adccb to
91115b9
Compare
dgageot
force-pushed
the
simplify-kaniko
branch
3 times, most recently
from
ba5cbaf to
d976dba
Compare
dgageot
changed the title
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
simplify-kaniko
branch
from
d976dba to
097229f
Compare
tejal29
approved these changes
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the GCS build context for Kaniko and instead always defaults to local directory. This seems to create much less friction and makes it possible to simplify the codebase a lot.