Merged
Conversation
loosebazooka
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
Member
|
FTR: #3369 (comment) and #3369 (comment) |
chanseokoh
approved these changes
Jan 8, 2020
| type projectKey string | ||
|
|
||
| func getProjectKey(workspace string, a *latest.JibArtifact) projectKey { | ||
| return projectKey(workspace + "+" + a.Project) |
Member
There was a problem hiding this comment.
As discussed, the fix in this PR make sense. I'll just let other Go folks to approve this particular implementation.
tejal29
approved these changes
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If two jib projects had clashing Project fields (even empty), they would trigger refreshing dependencies on every cycle of the skaffold dev loop. This creates a projectKey from the workspace and the project and uses it as the key.
While nothing was broken before, this provides the functionality we actually expected.