Skip to content

Empty, non-nil sync = sync all the files and infer destination#3496

Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:auto-sync-v2
Jan 21, 2020
Merged

Empty, non-nil sync = sync all the files and infer destination#3496
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:auto-sync-v2

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jan 10, 2020

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2020

Codecov Report

Merging #3496 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/defaults/defaults.go 94.38% <100%> (+0.12%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot dgageot force-pushed the auto-sync-v2 branch 5 times, most recently from 301eaf8 to badeb8f Compare January 20, 2020 07:23
Signed-off-by: David Gageot <david@gageot.net>
Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkubala nkubala merged commit 5ee3f91 into GoogleContainerTools:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants