Use origin/master as baseline for schema version check#3501
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Jan 15, 2020
Merged
Use origin/master as baseline for schema version check#3501dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Codecov Report
|
dgageot
approved these changes
Jan 15, 2020
Contributor
Author
|
Hmm.. the failing kaniko test seems unrelated to me. |
Contributor
|
yeah, let's ignore that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is just a small teak to improve the usability of the schema version test.
Before it used the
masterbranch as the reference version. However, this branch is not automatically updated by git when fetching changes from remote. On the other hand, theorigin/masterbranch is reset to the newest version on every pull/fetch from origin. Hence, the reference version automatically updates even if the user never updates hismasterbranch.This assumes that users have a standard setup for remote repository names. But I think this is as widespread as the name
master.User facing changes
n/a
Next PRs.
n/a
Submitter Checklist
n/a
Reviewer Notes