Skip to content

Use origin/master as baseline for schema version check#3501

Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
corneliusweig:w/use-origin-master-ref
Jan 15, 2020
Merged

Use origin/master as baseline for schema version check#3501
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
corneliusweig:w/use-origin-master-ref

Conversation

@corneliusweig
Copy link
Copy Markdown
Contributor

Description

This is just a small teak to improve the usability of the schema version test.

Before it used the master branch as the reference version. However, this branch is not automatically updated by git when fetching changes from remote. On the other hand, the origin/master branch is reset to the newest version on every pull/fetch from origin. Hence, the reference version automatically updates even if the user never updates his master branch.

This assumes that users have a standard setup for remote repository names. But I think this is as widespread as the name master.

User facing changes

n/a

Next PRs.

n/a

Submitter Checklist

n/a

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2020

Codecov Report

Merging #3501 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 52.87% <0%> (-4.6%) ⬇️

@dgageot dgageot self-assigned this Jan 15, 2020
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jan 15, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 15, 2020
@corneliusweig
Copy link
Copy Markdown
Contributor Author

Hmm.. the failing kaniko test seems unrelated to me.

@dgageot
Copy link
Copy Markdown
Contributor

dgageot commented Jan 15, 2020

yeah, let's ignore that

@dgageot dgageot merged commit 5b2e32c into GoogleContainerTools:master Jan 15, 2020
@corneliusweig corneliusweig deleted the w/use-origin-master-ref branch January 15, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants