Skip to content

Allow 2020 copyright year#3511

Merged
balopat merged 1 commit intomasterfrom
update-boilerplate-copyright-year
Jan 15, 2020
Merged

Allow 2020 copyright year#3511
balopat merged 1 commit intomasterfrom
update-boilerplate-copyright-year

Conversation

@loosebazooka
Copy link
Copy Markdown
Member

@loosebazooka loosebazooka commented Jan 15, 2020

Allows 2019|2020.

Previously when only 2019 was used, it was a hard requirement that all files use 2019, so any new file added would require a 2019 copyright header.

With this change, there will not be a way to ensure that new files use 2020 except by human 👀 but we preserve the original copyright year on files that were created earlier than 2020.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2020

Codecov Report

Merging #3511 into master will not change coverage.
The diff coverage is n/a.

@balopat
Copy link
Copy Markdown
Contributor

balopat commented Jan 15, 2020

Thanks for this :) yeah, I think that's fine / I can modify the script to ensure year of creation = today's year.
Last year I kinda messed this up and updated the copyright year to 2019 on all files, I might fix that with this change, as I learned that the policy is to keep the copyright year the creation year.

@balopat balopat merged commit 3edcf53 into master Jan 15, 2020
@chanseokoh chanseokoh deleted the update-boilerplate-copyright-year branch January 15, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants