[doc] There’s no gcsBucket config anymore#3514
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jan 16, 2020
Merged
[doc] There’s no gcsBucket config anymore#3514dgageot merged 1 commit intoGoogleContainerTools:masterfrom
gcsBucket config anymore#3514dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
force-pushed
the
gcs-bucket-no-more
branch
from
544f98e to
2229e5f
Compare
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
gcs-bucket-no-more
branch
from
2229e5f to
06a1de4
Compare
balopat
approved these changes
Jan 16, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM - hmmm...when did we remove gcsBucket? Did we remove it in a backwards compatible way? It was technically a GA feature, hence we shouldn't remove it before 6 months...
Contributor
Author
|
@balopat it's removed in a compatible way. Nothing will fail if people use it, it'll just sync from local files instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net