Skip to content

skip-build shouldn't detect builders#3528

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
balopat:speed_up_skip_build
Jan 18, 2020
Merged

skip-build shouldn't detect builders#3528
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
balopat:speed_up_skip_build

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Jan 18, 2020

When --skip-build is passed in, skaffold init should just skip artifacts section in the skaffold.yaml. This works, however currently we still traverse into the subdirectories and detect all the builders! This PR removes that issue.

Note: There is no significant time diff on my laptop weirdly on the skaffold repo between master and this version. Maybe I'm missing something, or artifact detection is fast...

This also helps moving the design toward a visitor pattern, where I could turn on and off certain visitors that aggregate the state independently in the analysis struct.

@balopat balopat changed the title skip build passed in skip-build shouldn't detect builders Jan 18, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2020

Codecov Report

Merging #3528 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 29.12% <50%> (-0.29%) ⬇️

@dgageot dgageot merged commit 0b8bd59 into GoogleContainerTools:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants