Skip to content

init refactor/clearer k8s manifest parsing#3531

Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom
balopat:init_refactor/k8smanifest_parsing
Jan 19, 2020
Merged

init refactor/clearer k8s manifest parsing#3531
balopat merged 2 commits intoGoogleContainerTools:masterfrom
balopat:init_refactor/k8smanifest_parsing

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Jan 19, 2020

small refactoring, cleanup in parsing k8s yamls in skaffold init.
The main changes:

  • introduce yamlObject type alias for readability
  • split out image parsing from yaml parsing into a single responsibility function parseKubernetesObjects and then using that in Kubernetes manifest file detection instead of image parsing

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2020

Codecov Report

Merging #3531 into master will increase coverage by <.01%.
The diff coverage is 95.83%.

Impacted Files Coverage Δ
pkg/skaffold/util/util.go 86.48% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 65.87% <100%> (ø) ⬆️
pkg/skaffold/initializer/kubectl/kubectl.go 84.61% <95.45%> (+1.28%) ⬆️
pkg/skaffold/initializer/init.go 29.12% <0%> (-0.29%) ⬇️

@balopat balopat merged commit 2ba2af8 into GoogleContainerTools:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants