[init refactor] introducing init analyzers#3533
Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom Jan 20, 2020
Merged
[init refactor] introducing init analyzers#3533balopat merged 2 commits intoGoogleContainerTools:masterfrom
balopat merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
balopat
changed the title
Codecov Report
|
balopat
force-pushed
the
init_refactor/analyzers
branch
2 times, most recently
from
98a28f7 to
15e12ca
Compare
dgageot
approved these changes
Jan 20, 2020
Contributor
dgageot
left a comment
dgageot
left a comment
There was a problem hiding this comment.
Looks good to me with a few nits
pkg/skaffold/initializer/analyze.go
Outdated
| ) | ||
|
|
||
| type analysis struct { | ||
| kubectlAnalyzer *KubectlAnalyzer |
Contributor
There was a problem hiding this comment.
Do these three types need to be exposed?
Contributor
Author
There was a problem hiding this comment.
Actually, they don't!
balopat
force-pushed
the
init_refactor/analyzers
branch
from
15e12ca to
7af6f16
Compare
Contributor
Author
|
Thanks for the quick review! I'll fix the nits tomorrow morning!:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring - shouldn't change anything functionally.
Introducing analyzers in the
initializerpackage.An Analyzer is basically implementing a Visitor pattern, can react to EnterDir and ExitDir events and can be called on each file. This creates a more composable design that is open for extension but closed for modification.
Also added tests to cover config generation logic.