Add labels to render#3558
Conversation
Codecov Report
|
| labels: []Labeller{}, | ||
| input: `apiVersion: v1 | ||
| kind: Pod | ||
| metadata: |
There was a problem hiding this comment.
was there a reason for adding this in input?
metadata
namespace: default
There was a problem hiding this comment.
Yes! If metadata doesn't exist, the default labeller doesn't execute, therefore not adding any labels.
Without it skaffold.dev/deployer: kubectl won't be added.
Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de>
Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de>
Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de>
Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de>
|
@arminbuerkle i rebased your branch on latest master and added another test If you give me permission to push to your branch, i can update this PR and merge it. |
@tejal29 i added you as a collaborator to our repository. For some reason i don't have the |
d15f474 to
8add2ed
Compare
|
@arminbuerkle i got the request! Thanks! |
* Add labeller to render Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * Add labeller to integration test Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * Add kustomize render labeller unit test Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * Add kubectl render labeller unit test Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * rebase from master and add one more test Co-authored-by: Tejal Desai <tejal29@gmail.com>
* Add labeller to render Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * Add labeller to integration test Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * Add kustomize render labeller unit test Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * Add kubectl render labeller unit test Signed-off-by: Armin Buerkle <armin.buerkle@alfatraining.de> * rebase from master and add one more test Co-authored-by: Tejal Desai <tejal29@gmail.com>
Fixes #3482.
Description
Adds the
--labeloption toskaffold render.@nkubala didn't have much time the last weeks, but here is the follow up of #3110 (comment)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes
Add
--labeloption toskaffold render