Skip to content

Show test output for failed tests, remove -v flag#3569

Merged
dgageot merged 4 commits intomasterfrom
detailed-test-output
Jan 24, 2020
Merged

Show test output for failed tests, remove -v flag#3569
dgageot merged 4 commits intomasterfrom
detailed-test-output

Conversation

@loosebazooka
Copy link
Copy Markdown
Member

@loosebazooka loosebazooka commented Jan 23, 2020

Looks like I did the wrong thing in #3548

Remove the -v flags and include detailed failed test output instead.

This only applies to macOS/linux builds, windows runs its tests without using the gotest.sh script: https://github.com/GoogleContainerTools/skaffold/blob/master/.travis.yml#L49 (which probably doesn't need the -v flag either, I think I misunderstood what the default was as I didn't realize this script did what it did)

The difference in output is:
OLD:

=== Failed Tests ===                                                                                                      
pkg/skaffold/build/jib/TestGetSyncMapFromSystem/direct_only
pkg/skaffold/build/jib/TestGetSyncMapFromSystem

NEW:

=== Failed Tests ===
/pkg/skaffold/build/jib/TestGetSyncMapFromSystem/direct_only
    --- FAIL: TestGetSyncMapFromSystem/direct_only (0.00s)
        sync_test.go:126: *jib.SyncMap differ (-got, +want):   &jib.SyncMap{                     
                "/tmp/skaffold684430519/dep1": {                                                                          
                        Dest:     []string{"/target/dep1"},                                                               
                        FileTime: s"2020-01-23 15:05:53.741546968 -0500 EST",       
            -           IsDirect: true,                                                                                   
            +           IsDirect: false,                                                                                  
                },                                                                                                        
              }    
/pkg/skaffold/build/jib/TestGetSyncMapFromSystem
    --- FAIL: TestGetSyncMapFromSystem (0.00s)

example failure in travis:

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2020

Codecov Report

Merging #3569 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/debug/debug.go 45.16% <0%> (-1.51%) ⬇️
pkg/skaffold/debug/transform.go 89.37% <0%> (+0.13%) ⬆️
pkg/skaffold/util/tar.go 52.87% <0%> (+13.16%) ⬆️
pkg/skaffold/initializer/init.go 51.16% <0%> (+13.95%) ⬆️
pkg/skaffold/build/buildpacks/metadata.go 100% <0%> (+72.72%) ⬆️

@loosebazooka
Copy link
Copy Markdown
Member Author

loosebazooka commented Jan 23, 2020

hold up one second, might be outputting duplicate test outputs... done

@dgageot dgageot merged commit fc079c9 into master Jan 24, 2020
@briandealwis briandealwis deleted the detailed-test-output branch April 14, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants