Show test output for failed tests, remove -v flag#3569
Merged
Conversation
dgageot
suggested changes
Jan 23, 2020
Codecov Report
|
e891822 to
32c8186
Compare
Member
Author
|
|
dgageot
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like I did the wrong thing in #3548
Remove the
-vflags and include detailed failed test output instead.This only applies to macOS/linux builds, windows runs its tests without using the gotest.sh script: https://github.com/GoogleContainerTools/skaffold/blob/master/.travis.yml#L49 (which probably doesn't need the
-vflag either, I think I misunderstood what the default was as I didn't realize this script did what it did)The difference in output is:
OLD:
NEW:
example failure in travis: