Automatically handle —no-pull option on pack.#3576
Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom Jan 24, 2020
Merged
Automatically handle —no-pull option on pack.#3576balopat merged 2 commits intoGoogleContainerTools:masterfrom
pack.#3576balopat merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
bp-auto-nopull
branch
from
a5cf357 to
fd4fd29
Compare
balopat
approved these changes
Jan 24, 2020
briandealwis
approved these changes
Jan 24, 2020
| p.images[builderRunnerPair{ | ||
| builder: builder, | ||
| runner: runImage, | ||
| }] = true |
Member
There was a problem hiding this comment.
This was a bit hard to parse!
Contributor
Author
There was a problem hiding this comment.
I made that clearer
Contributor
Author
|
kokoro is failing for unrelated reason (TestBuildKanikoInsecureRegistry) |
Instead of having the user handle that, Skaffold will always pull images on the first build and on each subsequent builds, pack will be told to not pull. Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
bp-auto-nopull
branch
from
fd4fd29 to
b6b1339
Compare
Member
|
One side-effect is that it makes it difficult to try out builder changes locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having the user handle that, Skaffold will always pull images on the first build and on each subsequent builds, pack will be told to not pull.
Signed-off-by: David Gageot david@gageot.net