Enable multiple kustomizations in the kustomize deployer#3585
Merged
balopat merged 8 commits intoGoogleContainerTools:masterfrom Jan 27, 2020
Merged
Enable multiple kustomizations in the kustomize deployer#3585balopat merged 8 commits intoGoogleContainerTools:masterfrom
balopat merged 8 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
f3ea6b4 to
31ec48f
Compare
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
PRs GoogleContainerTools#3577 and GoogleContainerTools#3578 introduced a conflict with respect to trailing newlines.
31ec48f to
eac30aa
Compare
balopat
approved these changes
Jan 26, 2020
Contributor
There was a problem hiding this comment.
This looks good to me, thank you @corneliusweig! And thanks for fixing the init_test.go bug - our lines has crossed there somehow with out of order PR merges or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1872.
Description
So far, the kustomize deployer only accepted a single path to a kustomization folder. This required an umbrella kustomization when working with multiple kustomization folders. On the other hand, for helm it has always been possible to deploy multiple charts, so that the UX between the differnent deployers was kind of inconsistent as pointed out in #1872.
Therefore, this PR enables multiple kustomization folders/paths in a single deployer stanza.
User facing changes
The (
string) key changed todeploy.kustomize.paths([]string). When not specified, it defaults to[]string{"."}and behaves equivalently to the previous config version.Before
The pipeline had a key
deploy.kustomize.pathof typestringto specify a single kustomization folder. When empty it defaults to".".After
The pipeline has a key
deploy.kustomize.pathsof type[]stringto specify a multiple kustomization folders. When empty (nilor length zero) it defaults to[]string{"."}.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes