Better output for Docker commands#3607
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jan 29, 2020
Merged
Conversation
Signed-off-by: David Gageot <david@gageot.net>
balopat
approved these changes
Jan 29, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
can you elaborate how this helps? in non-terminal cases it doesn't try to print colors?
Contributor
Author
|
@balopat sorry. It's supposed to behave like the docker CLI does. Instead of printing information on new lines, it'll update lines in place. If the output is not a terminal, then it'll behave like before. I remember trying to activate that a couple of times and it wasn't working on Matt's machine and your machine. The code I used was a bit different. I hope it works now. Can you try pushing an image? |
Codecov Report
|
Contributor
|
Nice! Instead of this:
I have the arrows flowing:
|
kissmikijr
pushed a commit
to kissmikijr/skaffold
that referenced
this pull request
Feb 3, 2020
Signed-off-by: David Gageot <david@gageot.net>
kissmikijr
pushed a commit
to kissmikijr/skaffold
that referenced
this pull request
Feb 3, 2020
Signed-off-by: David Gageot <david@gageot.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better output for docker build|push|pull|load
Signed-off-by: David Gageot david@gageot.net