Merged
Conversation
Signed-off-by: David Gageot <david@gageot.net>
This makes the Makefile faster for other targets. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
|
We don’t need a target to go build for every GOOS since this done by `make cross`. Signed-off-by: David Gageot <david@gageot.net>
At release time, we build in a Docker container so the path is predictable. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
nkubala
approved these changes
Feb 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves multiple slowness issues with the current Makefile:
make generate-statikshould make its inputs and outputs explicit so that we can avoid the cost of regeneratingThe net result is that
makeandmake installwill be faster to find out that nothing needs to be rebuilt and will be faster to rebuild changes to the Go code.cc @nkubala @tstromberg This should fix the issue you had with
make