Conversation
Codecov Report
|
dgageot
suggested changes
Feb 23, 2020
DEVELOPMENT.md
Outdated
|
|
||
| * Finally, before committing your final changes and opening your pull request, be sure and run `make test` locally. This will regenerate the JSON schemas for the skaffold config with your new changes. Commit the resulting changes autogenerated by the scripts. | ||
|
|
||
| For more details behind the logic of config changes see [the Skaffold config management doc](https://docs.google.com/document/d/e/2PACX-1vRBN1vHjSGbs3ZmdvyzzhBn48NjeuP4OiTTG5mec_YrRzNDL63pFa1Xy1rgCUNiQXTjAE1QyvCr5yxX/pub). |
Contributor
There was a problem hiding this comment.
Is the document supposed to be public? I can't access it
Contributor
Author
There was a problem hiding this comment.
It is supposed to be public, huh, I'll update.
dgageot
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2775.