Refactor helm deployer to prepare for helm3 support#3729
Merged
nkubala merged 3 commits intoGoogleContainerTools:masterfrom Feb 26, 2020
Merged
Refactor helm deployer to prepare for helm3 support#3729nkubala merged 3 commits intoGoogleContainerTools:masterfrom
nkubala merged 3 commits intoGoogleContainerTools:masterfrom
Conversation
tstromberg
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
tstromberg
changed the title
Codecov Report
|
nkubala
reviewed
Feb 25, 2020
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
a few nits but at first glance I love this
nkubala
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With any luck, there are no behavioral changes.
deployReleasewas split intoinstallArgsto reduce complexity. This is important because I am about to add complexity to how installArgs is calculated.To prepare for #2142