Skip to content

Support go Templates in Custom Builder commands#3754

Merged
dgageot merged 4 commits intoGoogleContainerTools:masterfrom
dgageot:fix-3753
Feb 28, 2020
Merged

Support go Templates in Custom Builder commands#3754
dgageot merged 4 commits intoGoogleContainerTools:masterfrom
dgageot:fix-3753

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Feb 28, 2020

Fixes #3753

Signed-off-by: David Gageot <david@gageot.net>
Fixes GoogleContainerTools#3753

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2020

Codecov Report

Merging #3754 into master will increase coverage by 0.01%.
The diff coverage is 84.21%.

Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 73.89% <100%> (+0.53%) ⬆️
pkg/skaffold/util/env_template.go 100% <100%> (ø) ⬆️
pkg/skaffold/build/misc/env.go 100% <100%> (+12.5%) ⬆️
pkg/skaffold/deploy/helm.go 77.47% <100%> (+0.29%) ⬆️
pkg/skaffold/build/custom/script.go 52.38% <40%> (-1.47%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
pkg/skaffold/sync/sync.go 72.57% <0%> (+0.31%) ⬆️

@tejal29 tejal29 self-assigned this Feb 28, 2020
Co-Authored-By: Tejal Desai <tejal29@gmail.com>
@dgageot dgageot merged commit c2877a6 into GoogleContainerTools:master Feb 28, 2020
@nkubala
Copy link
Copy Markdown
Contributor

nkubala commented Feb 29, 2020

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Go templates in custom command declaration

4 participants