skaffold init and buildpacks: skip dependencies#3758
Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom Feb 28, 2020
Merged
skaffold init and buildpacks: skip dependencies#3758balopat merged 2 commits intoGoogleContainerTools:masterfrom
balopat merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
dgageot
changed the title
Codecov Report
|
Fixes GoogleContainerTools#3568 Signed-off-by: David Gageot <david@gageot.net>
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
LGTM but we should log something to the users since the node_modules and vendor packages are not unusual to be found.
tejal29
reviewed
Feb 28, 2020
| { | ||
| description: "NodeJS", | ||
| path: "path/to/package.json", | ||
| path: filepath.Join("path", "to", "package.json"), |
Contributor
There was a problem hiding this comment.
just for completeness add corner test cases for
go.mod, package.json -> i.e. no filepath.Base = empty string
and somedir/vendor/go.mod -> i.e vendor not first parent.
tejal29
approved these changes
Feb 28, 2020
Contributor
tejal29
left a comment
tejal29
left a comment
There was a problem hiding this comment.
LGTM. just few nits on more test cases
Signed-off-by: David Gageot <david@gageot.net>
balopat
reviewed
Feb 28, 2020
| name := filepath.Base(path) | ||
| switch filepath.Base(path) { | ||
| case "package.json": | ||
| return !hasParent(path, "node_modules") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3568
Signed-off-by: David Gageot david@gageot.net