Merged
Conversation
dgageot
force-pushed
the
go1.14
branch
2 times, most recently
from
a4dddca to
464934b
Compare
Contributor
|
@dgageot can you rebase? |
Will make it easier to switch to another version of Go. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Contributor
Author
|
@nkubala Can you take another look, please? |
nkubala
approved these changes
Mar 10, 2020
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
tried out make, make cross, and gcloud builds submit on my Mac and they work fine.
|
@nkubala see Homebrew/homebrew-core#51233 (comment), what are the chances of this being released as a patch to |
Contributor
|
@mjgallag looks like this was addressed by the homebrew folks in that PR. we'll ship this out with the release this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to Go 1.14