Skip to content

unhide status check and on by default#3792

Merged
nkubala merged 1 commit intomasterfrom
revert-3791-revert-3790-revert-3782-revert-3639-unhide-status-check
Mar 10, 2020
Merged

unhide status check and on by default#3792
nkubala merged 1 commit intomasterfrom
revert-3791-revert-3790-revert-3782-revert-3639-unhide-status-check

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Mar 6, 2020

Reverts #3791.

The Revert^4.
!!! Only merge after 1.5.0 !!!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2020

Codecov Report

Merging #3792 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍

@nkubala nkubala merged commit c9be421 into master Mar 10, 2020
@briandealwis briandealwis deleted the revert-3791-revert-3790-revert-3782-revert-3639-unhide-status-check branch April 14, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants