Skip to content

Fix issues in skaffold init#3840

Merged
dgageot merged 5 commits intoGoogleContainerTools:masterfrom
dgageot:fix-skaffold-init
Mar 19, 2020
Merged

Fix issues in skaffold init#3840
dgageot merged 5 commits intoGoogleContainerTools:masterfrom
dgageot:fix-skaffold-init

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Mar 19, 2020

  • Close files
  • Don't panic on random yaml files
  • Parse skaffold configs only if they are yaml|yml|json files

dgageot added 2 commits March 19, 2020 17:15
Signed-off-by: David Gageot <david@gageot.net>
Some yaml files have non-string keys

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the fix-skaffold-init branch from a6c19dd to dd37955 Compare March 19, 2020 17:43
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3840 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 75% <100%> (+1.92%) ⬆️
pkg/skaffold/docker/docker_init.go 100% <100%> (ø) ⬆️
pkg/skaffold/initializer/analyze/analyze.go 89.09% <100%> (ø) ⬆️
pkg/skaffold/initializer/init.go 37.2% <50%> (-1.43%) ⬇️
pkg/skaffold/kubernetes/util.go 87.3% <75%> (-2.36%) ⬇️
pkg/skaffold/docker/dependencies.go 75% <0%> (+1.08%) ⬆️

dgageot added 2 commits March 19, 2020 19:36
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 7e06752 into GoogleContainerTools:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants