Skip to content

Fix of documentation issue #3266 microservices example is broken#3867

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
DmitriyStoyanov:master
Mar 24, 2020
Merged

Fix of documentation issue #3266 microservices example is broken#3867
balopat merged 1 commit intoGoogleContainerTools:masterfrom
DmitriyStoyanov:master

Conversation

@DmitriyStoyanov
Copy link
Copy Markdown
Contributor

@DmitriyStoyanov DmitriyStoyanov commented Mar 24, 2020

Fixes: 3266
Related: #3266 (comment)

Description

Example of using in microservices is wrong after removal of Service in 3f93642
After commited changes all works fine

All information described in issue #3266

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@DmitriyStoyanov
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2020

Codecov Report

Merging #3867 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot dgageot self-assigned this Mar 24, 2020
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Mar 24, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Mar 24, 2020
@balopat balopat merged commit 15a116a into GoogleContainerTools:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants