Simplify Debug Transformer interface and allow Apply to fail on images#3931
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Apr 14, 2020
Merged
Conversation
briandealwis
requested review from
balopat,
loosebazooka and
nkubala
as code owners
Codecov Report
|
- avoid panics by returning a ContainerDebugConfiguration instead of a pointer - allow returning a different debug-helper image - return a more helpful error message
briandealwis
force-pushed
the
simplify-apply
branch
from
c7d4edb to
4c26da9
Compare
dgageot
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContainerDebugConfigurationinstead of a pointerApply()is unable to be applied