Skip to content

Improve Debug's Go docs#3949

Merged
briandealwis merged 2 commits intomasterfrom
briandealwis-patch-3
Apr 14, 2020
Merged

Improve Debug's Go docs#3949
briandealwis merged 2 commits intomasterfrom
briandealwis-patch-3

Conversation

@briandealwis
Copy link
Copy Markdown
Member

From user feedback:

  • "self-identify" is cryptic
  • note that the apps should not use Alpine/MUSL, and include the error message seen in such circumstances

- user feedback that "self-identify" is cryptic
- should not use Alpine/MUSL, and include odd error message
@briandealwis briandealwis added docs-modifications runs the docs preview service on the given PR area/docs labels Apr 14, 2020
@briandealwis briandealwis requested a review from dgageot April 14, 2020 14:20
generally useful configuration.
- Go applications should be built without optimizations, so your build should be capable of building with
`-gcflags='all=-N -l'`. Skaffold [_Profiles_]({{< relref "/docs/environment/profiles.md" >}}) are a useful option.
- Alpine/MUSL-based apps are not supported at the moment, and usually results in cryptic errors like
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/results/result?

@container-tools-bot
Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.

1 similar comment
@container-tools-bot
Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 14, 2020
@container-tools-bot
Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.

Copy link
Copy Markdown
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Apr 14, 2020
@container-tools-bot
Copy link
Copy Markdown

Please visit http://34.94.251.4:1313 to view changes to the docs.

@container-tools-bot
Copy link
Copy Markdown

Error creating deployment, please see controller logs for details.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2020

Codecov Report

Merging #3949 into master will not change coverage.
The diff coverage is n/a.

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 14, 2020
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Apr 14, 2020
@briandealwis briandealwis merged commit 66da664 into master Apr 14, 2020
@briandealwis briandealwis deleted the briandealwis-patch-3 branch April 14, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants