Add error codes to event api to send error codes to Skaffold Event API#3954
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Apr 15, 2020
Merged
Conversation
Codecov Report
|
46f753f to
a01adfc
Compare
dgageot
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: This is an internal work item requested by IDEs to better report failure cause.
Description
This change
ErrorCodeThis Enum is added to each
errorspackage atpkg/skaffold/errorswith a functionErrorCodeFromErrorwhich will responsible to translate an error string to error code.Currently this returns error code
COULD_NOT_DETERMINEUser facing changes (remove if N/A)
New field for IDEs to consume.
Follow-up Work (remove if N/A)
The follow work will include,
pkg/skaffold/<pkg>e.g. below and converting them to distinct error codes wherever possible.ErrorCodeFromErrorwhich could be as simple as regex matching.