Skip to content

Changing test config invalidates the build cache#3984

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-3982
Apr 21, 2020
Merged

Changing test config invalidates the build cache#3984
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-3982

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Apr 20, 2020

Fixes #3982

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2020

Codecov Report

Merging #3984 into master will decrease coverage by 0.05%.
The diff coverage is 22.22%.

Impacted Files Coverage Δ
pkg/skaffold/runner/new.go 69.79% <22.22%> (-2.93%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

Fixes GoogleContainerTools#3982

Signed-off-by: David Gageot <david@gageot.net>
@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Apr 21, 2020

The build failed due to OOO. Restarted the build.
the PR looks good to me.

@dgageot dgageot merged commit 07993d1 into GoogleContainerTools:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing test config should invalidate the build cache

3 participants