Support --default-repo=‘’ to erase the value from global config#3990
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Apr 23, 2020
Merged
Support --default-repo=‘’ to erase the value from global config#3990dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
nkubala
reviewed
Apr 20, 2020
dgageot
requested review from
TadCordle,
chanseokoh and
loosebazooka
as code owners
dgageot
force-pushed
the
fix-3923
branch
2 times, most recently
from
8d096da to
9367f0d
Compare
dgageot
force-pushed
the
fix-3923
branch
3 times, most recently
from
dcef125 to
2c20a91
Compare
Fixes GoogleContainerTools#3923 Signed-off-by: David Gageot <david@gageot.net>
Contributor
Author
|
@briandealwis @nkubala I came up with a nicer solution, I think. Feels much less hacky |
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
LGTM: a much nicer solution.
| // CLI flag takes precedence. | ||
| if cliValue != "" { | ||
| return cliValue, nil | ||
| if cliValue != nil { |
Member
There was a problem hiding this comment.
We should have a test specifically for GetDefaultRepo.
Contributor
Author
|
Let me merge that and add a few more tests. Maybe also change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3923
Signed-off-by: David Gageot david@gageot.net