Gracefully shutdown RPC servers.#4010
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Apr 23, 2020
Merged
Conversation
Codecov Report
|
nkubala
approved these changes
Apr 22, 2020
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
couldn't tell if the integration test failure was a flake or not, so I restarted the job. assuming it passes this LGTM
Contributor
Author
|
Looks like it's not a flake |
dgageot
force-pushed
the
graceful-shutdown
branch
from
5d386cd to
a4b9902
Compare
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
graceful-shutdown
branch
from
a4b9902 to
a9470f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tejal29 can you try this out and see if it's better now?
Fixes #3970
Maybe fixes #3991
Signed-off-by: David Gageot david@gageot.net