Add codes for error types and detect terminated containers#4012
Merged
balopat merged 6 commits intoGoogleContainerTools:masterfrom Apr 24, 2020
Merged
Add codes for error types and detect terminated containers#4012balopat merged 6 commits intoGoogleContainerTools:masterfrom
balopat merged 6 commits intoGoogleContainerTools:masterfrom
Conversation
balopat
reviewed
Apr 23, 2020
proto/skaffold.proto
Outdated
| // COULD_NOT_GET_DOCKER_CLIENT = 7; | ||
| // COULD_NOT_GET_LOCAL_CLUSTER = 8; | ||
| // BUILDER_CLEANUP = 9; | ||
|
|
Contributor
There was a problem hiding this comment.
I think we could follow grouping by first digit similar to HTTP status codes (https://www.rfc-editor.org/rfc/rfc7231.txt)
I like the container errors being 3xx, and k8s infra errors 4xx, but then NO_ERROR should be 2xx, unknown 5xx, e.g. (unknown 500, unknown unsched 501) WDYT?
Contributor
Author
There was a problem hiding this comment.
sounds good. i have tried to group them, but not to the best!
balopat
added
the
docs-modifications
|
Please visit http://34.94.185.45:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
balopat
suggested changes
Apr 23, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM with nits:
- docs on error codes
- error code numbering
tejal29
added
the
docs-modifications
|
Please visit http://34.94.41.154:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
added
the
docs-modifications
|
Please visit http://34.94.185.45:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
added
the
docs-modifications
container-tools-bot
removed
the
docs-modifications
|
Please visit http://34.94.41.154:1313 to view changes to the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #3952
In this change, Diagnostic library will now return an error code for each error type e. g "ImgPullErr" or "RunContainerErr"
Skaffold pod health check will consume this error code and propogate it to IDEs in
ResourceStatusCheckEventfor them to determine what next actions could be taken.Description
User facing changes (remove if N/A)
None.
Follow-up Work (remove if N/A)
Add
ErrorCodetoResourceStatusCheckEventprotoHook up pod health check in
pkg/diagwith skaffold.