Use NODEJS_VERSION and NODE_ENV in detection#4021
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Apr 27, 2020
Merged
Use NODEJS_VERSION and NODE_ENV in detection#4021dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
briandealwis
requested review from
balopat,
dgageot,
loosebazooka,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4003
Description
Use
NODE_ENVandNODEJS_VERSION(used in RedHat's universal base images) to detect NodeJS images forskaffold debug.User facing changes (remove if N/A)
skaffold debugusesNODE_ENVandNODEJS_VERSIONto detect NodeJS applications.