Skip podspecs that already have a debug.cloud.google.com/config annotation#4027
Merged
dgageot merged 4 commits intoGoogleContainerTools:masterfrom Apr 30, 2020
Merged
Conversation
briandealwis
requested review from
balopat,
dgageot,
loosebazooka,
nkubala and
tejal29
as code owners
Codecov Report
|
tejal29
reviewed
Apr 29, 2020
Contributor
tejal29
left a comment
tejal29
left a comment
There was a problem hiding this comment.
LGTM except a minor docs note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip transforming a pod spec if it already has our debug annotation. This ability is useful if someone wants to explicitly configure debugging for a container image such as to customize the
dlvcommand-line used for a Go app.