Fail fast if minikube is used but not started#4042
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Apr 28, 2020
Merged
Fail fast if minikube is used but not started#4042dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
|
Signed-off-by: David Gageot <david@gageot.net>
briandealwis
approved these changes
Apr 28, 2020
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
Nice — I just hit this yesterday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4013