Skip to content

Fix default-repo handling for skaffold deploy#4074

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-3765
May 4, 2020
Merged

Fix default-repo handling for skaffold deploy#4074
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-3765

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Apr 30, 2020

Fix #3765

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2020

Codecov Report

Merging #4074 into master will decrease coverage by 0.04%.
The diff coverage is 26.31%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 69.44% <0.00%> (-11.21%) ⬇️
pkg/skaffold/runner/runner.go 0.00% <ø> (ø)
pkg/skaffold/runner/build_deploy.go 57.29% <35.71%> (-0.32%) ⬇️

@dgageot dgageot force-pushed the fix-3765 branch 2 times, most recently from d99f87f to 3293cb3 Compare April 30, 2020 14:36
Fix GoogleContainerTools#3765

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 6b6196f into GoogleContainerTools:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skaffold Deploy using -i for images doesn't respect default repository

3 participants