Use node wrapper to debug NodeJS apps#4086
Merged
dgageot merged 5 commits intoGoogleContainerTools:masterfrom May 5, 2020
Merged
Use node wrapper to debug NodeJS apps#4086dgageot merged 5 commits intoGoogleContainerTools:masterfrom
node wrapper to debug NodeJS apps#4086dgageot merged 5 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
|
nkubala
reviewed
May 4, 2020
Contributor
nkubala
left a comment
There was a problem hiding this comment.
so if I understand correctly, /dbg/nodejs/bin was added to the debug helper image in GoogleContainerTools/container-debug-support#34. but that image tag wasn't bumped anywhere here - where is that referenced in skaffold? i'm wondering if we integration tests that run in CI to make sure nothing in this image changes out from under our feet.
Member
Author
|
We live at |
dgageot
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2170
Description
Cause NodeJS apps to use the newly-introduced
nodewrapper.Many applications use NodeJS-based tools as part of their launch, like
npm, rather thaninvoke
nodedirectly. These intermediatenodeinstances may interpret the--inspectarguments. GoogleContainerTools/container-debug-support#34 introduced anodewrapper that only passes--inspectwhen provided an application script, and otherwise propagates--inspectvia an environment variable.One other minor change: this now sorts the environment variables when populating the k8s
Containerobjects to make comparisons stable in the tests.User facing changes
NodeJS apps that previously seemed undebuggable should now respond to debugging treatment.