Skip to content

--dry-run=client must replace --dry-run=true with kubectl >= 1.18#4096

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-4094
May 5, 2020
Merged

--dry-run=client must replace --dry-run=true with kubectl >= 1.18#4096
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-4094

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented May 4, 2020

Fixes #4094

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2020

Codecov Report

Merging #4096 into master will decrease coverage by 0.08%.
The diff coverage is 92.30%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/cli.go 90.90% <71.42%> (-3.83%) ⬇️
pkg/skaffold/kubectl/version.go 100.00% <100.00%> (ø)
pkg/skaffold/deploy/labeller.go 50.00% <0.00%> (-50.00%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@dgageot dgageot merged commit ff0d744 into GoogleContainerTools:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--dry-run=client must replace --dry-run=true with kubectl >= 1.18

3 participants