Skip to content

Only listen to pods for the current RunID#4097

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-1753
May 4, 2020
Merged

Only listen to pods for the current RunID#4097
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-1753

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented May 4, 2020

Fixes #1753

Signed-off-by: David Gageot david@gageot.net

@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented May 4, 2020

This is a reminder that we should fix #3745

@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2020 •
edited
Loading

Codecov Report

Merging #4097 into master will decrease coverage by 0.04%.
The diff coverage is 56.25%.

Impacted Files Coverage Δ
...skaffold/kubernetes/debugging/container_manager.go 43.28% <0.00%> (-5.05%) ⬇️
pkg/skaffold/runner/debugging.go 30.00% <0.00%> (-3.34%) ⬇️
...affold/kubernetes/portforward/forwarder_manager.go 31.57% <33.33%> (ø)
pkg/skaffold/kubernetes/log.go 39.47% <87.50%> (+0.53%) ⬆️
...g/skaffold/kubernetes/portforward/pod_forwarder.go 86.15% <100.00%> (+0.21%) ⬆️
pkg/skaffold/kubernetes/watcher.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/logger.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/portforwarder.go 100.00% <100.00%> (ø)

@cliffburdick cliffburdick mentioned this pull request May 4, 2020
Closed
@dgageot
Only listen to pods for the current RunID
a881930 
Fixes GoogleContainerTools#1753

Signed-off-by: David Gageot <david@gageot.net>
balopat
balopat approved these changes May 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 11b78e0 into GoogleContainerTools:master May 4, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
@dgageot dgageot mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

1 more reviewer

@balopat balopat balopat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--tail In Deploy Mode Mixes Outputs

3 participants

@dgageot @balopat @googlebot