Improve docker load output in bazel build#475
Merged
r2d4 merged 1 commit intoGoogleContainerTools:masterfrom Apr 27, 2018
Merged
Improve docker load output in bazel build#475r2d4 merged 1 commit intoGoogleContainerTools:masterfrom
r2d4 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Fixes GoogleContainerTools#416 Currently we add the streaming of son messages. It would be even better to stream them with the `isTerminal` flag set but it seems to fail on some setup. Signed-off-by: David Gageot <david@gageot.net>
r2d4
approved these changes
Apr 27, 2018
Contributor
r2d4
left a comment
r2d4
left a comment
There was a problem hiding this comment.
I'll document and investigate the terminal error when I have some time to test it on my workstation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #416
Currently we add the streaming of son messages.
It would be even better to stream them with the
isTerminalflag set but it seems to fail on somesetup.
Signed-off-by: David Gageot david@gageot.net