Add files to the context tarball with Unix separators.#489
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom May 5, 2018
Merged
Add files to the context tarball with Unix separators.#489dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Contributor
|
I’d setup a Windows CI on AppVeyor. Spoiler: some tests currently fail on
Windows
Le ven. 27 avr. 2018 à 18:23, dlorenc <notifications@github.com> a écrit :
… @dlorenc <https://github.com/dlorenc> requested your review on:
GoogleContainerTools/skaffold#489
<#489> Add files to
the context tarball with Unix separators. as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#489 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJXlyGNvcoMGP9DQAydlai1TYnr56WBks5ts0YQgaJpZM4TqoJd>
.
|
This was referenced Jun 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #442. I can't think of a good way to test this, since it would require running unit tests on Windows.
Any ideas?