alternative fix for #481#495
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom May 5, 2018
Merged
Conversation
which uses 2 separate environment variables adds a test to show it working #fixes 481
jstrachan
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
dlorenc
approved these changes
Apr 30, 2018
Contributor
dlorenc
left a comment
dlorenc
left a comment
There was a problem hiding this comment.
Nice! I like this approach. Do we need to add this to the documentation anywhere?
Contributor
Author
Contributor
|
LGTM. |
Contributor
|
@r2d4 do you want to merge this now or after Kubecon? |
Contributor
|
Thanks! This is really useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which uses 2 separate environment variables
adds a test to show it working