Skip fully qualified names when replacing images names#566
Merged
dgageot merged 5 commits intoGoogleContainerTools:masterfrom May 21, 2018
Merged
Skip fully qualified names when replacing images names#566dgageot merged 5 commits intoGoogleContainerTools:masterfrom
dgageot merged 5 commits intoGoogleContainerTools:masterfrom
Conversation
Contributor
Author
|
@jonjohnsonjr That's a good idea. |
dlorenc
reviewed
May 18, 2018
| if removed != "host:1234/user/container" { | ||
| t.Errorf("Tag vas not removed from an image name with port: %s ", removed) | ||
| func TestSplitTag(t *testing.T) { | ||
| var tests = []struct { |
Contributor
There was a problem hiding this comment.
Can we add a test case for digest?
Contributor
Author
There was a problem hiding this comment.
Should be done now!
pkg/skaffold/deploy/kubectl.go
Outdated
| return re.ReplaceAllString(image, "") | ||
| func splitTag(image string) (string, string) { | ||
| re := regexp.MustCompile(`(.*):([^/]+)$`) | ||
| matches := re.FindStringSubmatch(image) |
Contributor
There was a problem hiding this comment.
It might be a little more robust to reuse the name parsing utilities here: https://github.com/google/go-containerregistry/blob/master/name/ref.go
Fix GoogleContainerTools#565 Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dlorenc
approved these changes
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.