kaniko: pin image version to v0.1.0#592
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom May 25, 2018
Merged
Conversation
Contributor
Author
|
I manually verified this works |
Contributor
|
Thoughts re: pinning to a digest instead of a tag? |
Contributor
|
It's effectively the same for kaniko. We have effectively immutable tags. |
Contributor
Author
|
Done :) |
dgageot
suggested changes
May 25, 2018
Contributor
dgageot
left a comment
dgageot
left a comment
There was a problem hiding this comment.
nitpick: docker pull gcr.io/kaniko-project/executor:v0.1.0@sha256:501056bf52f3a96f151ccbeb028715330d5d5aa6647e7572ce6c6c55f91ab374 is also a valid reference
Contributor
Author
|
Ah thats clearer. Didn't know about that syntax. |
Contributor
Author
|
Updated |
dgageot
approved these changes
May 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #591